search

beyondcode / herd-community

82 stars 1 forks source link

[Bug]: Service "Add Service" modal has state of "Settings" modal when "Settings" was opened before "Add Service" #976

Open justusmoroni opened 2 weeks ago

justusmoroni commented 2 weeks ago

Platform

macOS

Operating system version

macOS Sonoma 14.6.1 (23G93)

System architecture

Intel (x86)

Herd Version

1.11.0 (Build: 33)

PHP Version

No response

Bug description

When adding or editing a service in the "Services" tab sometimes an existing service is changed instead of adding a new service.

Steps to reproduce

  1. Click on "Add Service" and create one service. E.g. "Queue".
  2. Click on "Settings" on the newly created service "Redis" image image
  3. Dismiss the "Settings" modal by pressing the escape key. I could not reproduce this behaviour when clicking the "Close" button.
  4. Click on "Add Service" again

image

Instead of adding a new service we are now editing the last service where we clicked "Settings". Sometimes when saving that i could successfully save the service and it was switched. Sometimes the whole application crashed instead.

When i only change the name saving is successful. image image

Relevant log output

No response

mpociot commented 5 days ago

Thanks for reporting this! Will be fixed in the next release