beyondcode / laravel-mailbox

Catch incoming emails in your Laravel application
https://beyondco.de/docs/laravel-mailbox/getting-started/introduction
MIT License
1.04k stars 127 forks source link

Laravel 11.x Compatibility #123

Closed laravel-shift closed 7 months ago

laravel-shift commented 8 months ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 8 months ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

laravel-shift commented 8 months ago

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift commented 8 months ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-mailbox.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "beyondcode/laravel-mailbox": "dev-l11-compatibility",
    }
}

Finally, run: composer update

peterthomson commented 7 months ago

The failing tests don't look amazing, but from some light internal testing it does look like this package works with Laravel 11. Anyone else tried it on L11?

wgriffioen commented 7 months ago

The failing tests are a result of the version bump to ^2.4 for zbateson/mail-mime-parser. I've forked the repository and applied all the changes from Shift without the version bump for mail-mime-parser and the tests seem to work fine. See: https://github.com/sendynl/laravel-mailbox/commit/d39e2e9dbc9a9058251fb4f764fd18464810cf75

@mpociot: Would you prefer me to create separate pull request with the updates for Laravel 11?

dniccum commented 7 months ago

Any updates on the progress of this item?