search

beyondcode / nova-filterable-cards

Add custom filters to your Nova metric cards
MIT License
58 stars 20 forks source link

Declaration FilterableValue aggregate not compatible #8

Open renege opened 4 years ago

renege commented 4 years ago

Hi, @sschlein @mpociot

Having issues on latest V2-version of Nova: 2.12.0

Declaration of Beyondcode\FilterableCard\FilterableValue::aggregate($request, $model, $function, $column = NULL) should be compatible with Laravel\Nova\Metrics\Value::aggregate($request, $model, $function, $column = NULL, $dateColumn = NULL)

This in my Nova Value Metric:

use Beyondcode\FilterableCard\FilterableValue;
use Laravel\Nova\Http\Requests\NovaRequest;
use Laravel\Nova\Metrics\Value;

class TotalAdvisors extends Value
{
    use FilterableValue;

Also tried to use the Trait use Beyondcode\FilterableCard\Filterable; > then I get no errors, but nothing will happen when I click the 3 dots ,while i expect a popup to open.