Failed test at t/ack-type.t line 97, against current dev HEAD: a6fda2611e5ca0127a1d70e10ab20ba3b71848b9

spazm commented 11 years ago

Behavior

failed test in t/ack-type.t when running make test in HEAD

Expected

no failed tests in HEAD.

Steps to Reproduce:

git clone https://github.com/petdance/ack2.git
cd ack2
cpanm --installdeps .
make test

...

t/ack-type.t ................. 3/12
#   Failed test at t/ack-type.t line 97.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = 't/swamp/html.html:2:<html><head><title>Boring test file </title></head>'
# Looks like you failed 1 test of 12.

with TEST_VERBOSE=1:

  not ok 12

#   Failed test at t/ack-type.t line 97.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = 't/swamp/html.html:2:<html><head><title>Boring test file </title></head>'# Looks like you failed 1 test of 12.
Dubious, test returned 1 (wstat 256, 0x100)

Current commit revision:

commit a6fda2611e5ca0127a1d70e10ab20ba3b71848b9
Author: Andy Lester <andy@petdance.com>
Date:   Sun Apr 28 19:15:05 2013 -0500

removed old documents that refer to ack 1.0

System:

Linux vm64 3.0.0-12-server #20-Ubuntu SMP Fri Oct 7 16:36:30 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
This is perl 5, version 12, subversion 4 (v5.12.4) built for x86_64-linux-gnu-thread-multi
(with 48 registered patches, see perl -V for more detail)

spazm commented 11 years ago

The failing test is TEST_NOTYPE_ACKRC_CMD_LINE_OVERRIDE

I ran git bisect prove t/ack-type.t and it shows the original commit f748962442badadab1b96f44d0c4186505b65a6a that added this test.

commit f748962442badadab1b96f44d0c4186505b65a6a
Author: Rob Hoelz <rob@hoelz.ro>
Date:   Sat Apr 27 18:53:14 2013 +0200

    Test that --type on command line overrides --notype in ackrc

    For GH #246

So maybe I'm special. What should I provide for debugging?

petdance commented 11 years ago

I don't know that there's any more than that to add. I think you get a prize for best ack bug report yet.

mmcclimon commented 11 years ago

This is the test we know is failing (looks like Rob wrote it for issue #246). Maybe we should wrap it in a todo, @petdance?

But seriously, a great bug report!

petdance commented 11 years ago

No TODO unless there's a reason we can't fix it now.

mmcclimon commented 11 years ago

Fixed in commit 7fac4f5.

spazm commented 11 years ago

I think you get a prize for best ack bug report yet.

woohoo!!

beyondgrep / ack2