beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

Ignore minified JavaScript #271

Closed mcandre closed 11 years ago

mcandre commented 11 years ago

It would also be helpful to ignore minified JavaScript such as jquery-x.y.z.min.js and backbone-min.js using --ignore-file=match:min\.js.

petdance commented 11 years ago

We already ignore minified javascript and CSS by default.

--ignore-file=match:/[.]min[.]js$/
--ignore-file=match:/[.]js[.]min$/
--ignore-file=match:/[.]min[.]css$/
--ignore-file=match:/[.]css[.]min$/

Should we expand that initial dot to include - as well?

Simply using --ignore-file=match:min\.js would ignore theremin.js or webmin.js or webmin.jsintro.html.

mcandre commented 11 years ago

Should we expand that initial dot to include - as well?

Yes, I think so. The majority convention for minified files is blahblahblah.min.js, but a few libraries such as Backbone use blahblahblah-min.js.

mmcclimon commented 11 years ago

Fixsed in rev d4152d0.