search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

squash needs to put ack stuff at the top #387

Closed petdance closed 11 years ago

petdance commented 11 years ago

Somehow ack-standalone is getting built with File::Next at the top. This is bad.

petdance commented 11 years ago

Fixed and pushed on the dev branch.

hoelzro commented 11 years ago

Why is having File::Next at the top an issue?

petdance commented 10 years ago

Because I have all the notes and comments to the user at the top of ack. Stuff like this:

#!/usr/bin/env perl
#
# This file, ack, is generated code.
# Please DO NOT EDIT or send patches for it.
#
# Please take a look at the source from
# http://github.com/petdance/ack2
# and submit patches against the individual files
# that build ack.
#

package main;

use strict;
use warnings;

use 5.008008;

# XXX Don't make this so brute force
# See also: https://github.com/petdance/ack2/issues/89

use Getopt::Long 2.35 ();

use Carp 1.04 ();

our $VERSION = '2.11_01';
# Check http://beyondgrep.com/ for updates

With File::Next, the first thing you see opening the file is File::Next, and the actual guts of ack are buried somewhere.