search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Should -g output be highlighted? #397

Closed hoelzro closed 10 years ago

hoelzro commented 10 years ago

When I look through a file list using ack -g, it might be nice to highlight the matches. Should we do this by default when the color option is active?

petdance commented 10 years ago

I think it would have to only be on if the user forced --color to be on. My assumption is that -g is going to be used as a source of data for something else.

hoelzro commented 10 years ago

That makes sense. But we should have -g highlight its matches if --color is active and we outputting to a terminal, yes?

petdance commented 10 years ago

Yes, if the user forces --color, But --color should default to off if -g is on.

hoelzro commented 10 years ago

Ok, cool.

hoelzro commented 10 years ago

I've implemented this; since we now have the option to do this, does it make sense to implement --passthru for -g as well?

petdance commented 10 years ago

No, --passthru does not belong on -g.

hoelzro commented 10 years ago

That's done, then.