search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Added rst support #413

Closed mrshu closed 10 years ago

mrshu commented 10 years ago

As described in #343 and previously implemented in https://github.com/petdance/ack/pull/166 this pull request adds support for reStructured Text.

hoelzro commented 10 years ago

Wow, sorry @mrshu; I didn't notice this until just now. Thoughts, @petdance?

petdance commented 10 years ago

I've never heard of RST before, and I haven't seen any +1 so I'm wary of adding it.

hoelzro commented 10 years ago

RST is a very common markup language used with Python programs. It's Python's POD, sort of.

petdance commented 10 years ago

Well that changes everything.

Should it be under --python just like .pod is under --perl?

hoelzro commented 10 years ago

That's a really good question...I would say leave it out for now; we can always add it later.

petdance commented 10 years ago

Sounds good. I'm OK with adding RST.

hoelzro commented 10 years ago

@mrshu Would you mind syncing up your changes with what's on the dev branch and pushing again?

mrshu commented 10 years ago

@hoelzro Thanks for reminding me, I just did.

hoelzro commented 10 years ago

Thanks, @mrshu!