beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

Stop using eval() for --output #421

Closed petdance closed 6 years ago

petdance commented 10 years ago

Bill Ricker rightly suggests that --output should be done with some sort of string eval that we do, rather than arbitrary code execution. I want to limit the output to only special variables like $1, $2, etc.

This will slow down output, but that's not the bottleneck in an ack run anyway.

petdance commented 6 years ago

This has been implemented in ack3. We will not be backporting it into ack 2.