search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

Windows Test fixes #435

Closed ispedals closed 10 years ago

ispedals commented 10 years ago

These commits fix test errors and result in the test suite passing on Windows. I have tested on strawberry perl 5.18.0 on Windows 8.1, strawberry perl 5.18.1 on Windows and perl 5.18.02 on Debian 3.2.0.4-486 to ensure no regressions occurred.

petdance commented 10 years ago

This looks fantastic. I will try to look at it tomorrow. Thank you!

petdance commented 10 years ago

Why the reversion of the error checking on the call to system()? Is there any problem with it being there?

petdance commented 10 years ago

We're still getting Windows failures, but different ones now.

http://cpantesters.org/distro/A/ack.html?grade=1&perlmat=2&patches=2&oncpan=2&distmat=3&perlver=ALL&osname=ALL&version=2.12

Scroll down to the 2.13_06

ispedals commented 10 years ago

Sorry, I have been busy. I reverted the error checking call to system() because there are some tests that result in a nonzero exit status on purpose (at least I think it's on purpose), such as in t/ack-c.t where the tests use the -c switch. This prevents these test from failing. The reintroduction of the check causes the same test failures to occur for me that are also being reported.