search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

removed -T in SheBang because of failed tests on Win32 #472

Closed ghost closed 8 years ago

ghost commented 10 years ago

The tests for App::Ack failed on my Windows 7 system with all Strawberry Perl versions (5.14 - 5.20).

I figured out, that the problem is the taint switch -T in shebang of these three tests.

If in taintmode File::Temp->tempdir does not create a directory in temporary directory of the user or system, but wrong in \ of drive, on which the tests for App::Ack are running. Becaus of this the tests fails.

Please check this.

petdance commented 10 years ago

I am very wary of removing the -T. We want -T as much as possible. -T serves an importance purpose and removing -T because it causes problems is like removing use warnings because it causes problems.

ghost commented 10 years ago

We want -T as much as possible.

In understand your decision, you are right. No problem.

I found out, that failing tests of App::Ack are a problem with File::Temp and the underlaying File::Spec::Win32. These modules do not find correctly the user temp directory.

I reported the Bug #96863 for PathTools and sent Win32.patch to Steffen Müller, the maintainer of File::Spec.

With my patch of File::Spec::Win32 the tests are running without a fail!

petdance commented 10 years ago

That's good news. Any idea when a new PathTools will get released?

ghost commented 10 years ago

Any idea when a new PathTools will get released?

No, sorry, i dont know and had got no answer from the maintainer of File::Spec. Lets wait a few days.