search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

Highlight the matched portion of filenames when using -g #476

Closed mcandre closed 10 years ago

mcandre commented 10 years ago

Highlighting the matched portion of text in ordinary ack content searches is helpful for visually getting to the core of the results. Could we use the same highlight colouring for the portion of file paths that match, when the -g option is used?

On one hand, this enhancement is a very minor concern. On the other, it is easy to implement (we already colorize content), and would be super helpful to many users.

hoelzro commented 10 years ago

This has been implemented (see #397), but you need to specify --color.

mcandre commented 10 years ago

This kind of works, and I would even put --color in my ~/.ackrc, but I do NOT want to force colors when piping into other programs.

I just want -g to have colors, in TTY's, by default. Please consider adding this enhancement.

On Tue, Jul 29, 2014 at 9:47 AM, Rob Hoelz notifications@github.com wrote:

Closed #476 https://github.com/petdance/ack2/issues/476.

— Reply to this email directly or view it on GitHub https://github.com/petdance/ack2/issues/476#event-146753287.

Cheers,

Andrew Pennebaker www.yellosoft.us