search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

v2.14 with "-l" not emitting all matching files. #491

Closed clonezone closed 7 years ago

clonezone commented 10 years ago

Using standalone ack v2.14:

> echo ' ' >space-newline.txt
> echo $' \n' >space-newline-newline.txt
> ack ' $' space-newline*.txt
space-newline-newline.txt
1:

space-newline.txt
1: 
> ack -l ' $' space-newline*.txt
space-newline.txt

This works fine with standalone ack v2.12.

hoelzro commented 10 years ago

Confirmed; b3617f1 is the culprit

petdance commented 10 years ago

This seems pretty bad. I'd like to put out a 2.16 when this gets fixed.

hoelzro commented 10 years ago

@petdance Should we just revert that commit, release, and work on getting an optimal fix in for 2.18?

petdance commented 10 years ago

Seems like that might be reasonable. I want to get a broken .t written for it first, to verify the broken behavior and then that the reverted commit fixes it.

hoelzro commented 10 years ago

My thoughts exactly.

hoelzro commented 10 years ago

There's a test and a fix in the dev branch. @clonezone Would you mind battle testing it a bit before we make a release? I ended up just fixing the problem instead of reverting, because the fix was small and easy.

clonezone commented 10 years ago

I can try it on the actual problem situation tomorrow morning.

clonezone commented 10 years ago

tack as of commit 17504aa361eef269c57f43c21e16d1705cd1e7c0 finds the same set of files as does ack standalone v2.12 in the situation that I had a problem with ack standalone v2.14.

hoelzro commented 10 years ago

@clonezone Thanks for checking! @petdance You wanna do that release tonight?

petdance commented 10 years ago

I'd like to. Let me see what I can do.

shlomif commented 9 years ago

So I have a patch for it in #498 , and there's another fix here. Can a fix be released?

petdance commented 9 years ago

Yes, a fix can be released. It's just a matter of me getting time to do so.

karenetheridge commented 9 years ago

@petdance can any assistance be rendered to do a release?

karenetheridge commented 9 years ago

I also just ran into a case where ack ' $' returned results, but ack -l ' $' returned nothing.

shlomif commented 9 years ago

@petdance : I can also help.

hoelzro commented 8 years ago

This should be fixed now.

shlomif commented 8 years ago

@hoelzro: thanks! Do you know when a new release will be made to CPAN?

hoelzro commented 8 years ago

@shlomif That's up to @petdance!

shlomif commented 8 years ago

@hoelzro : I see. It's been taking him a very long time, unfortunately.

petdance commented 7 years ago

Looks like this went out in 2.16.