search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Starting directory should override ignored directories #524

Closed jamischarles closed 7 years ago

jamischarles commented 9 years ago

tl;dr Starting directory should override previously set ignore options (including defaults)

This issue is born out of #523

Setup

mkdir temp
echo 'Bongo!' > temp/dir.txt

Tests ack --ignore-dir=temp Bongo temp This should return a result but doesn't. ack -f --ignore-dir=temp temp This should return dir.txt but doesn't.

hoelzro commented 9 years ago

@jamischarles This is resolved in Git HEAD as of 4091db4.

jamischarles commented 9 years ago

@hoelzro Awesome. When do you think this will make it into a release?

hoelzro commented 9 years ago

@jamischarles That's up to @petdance; I think he's been gearing up for a 2.16 release.

petdance commented 8 years ago

@jamischarles Can you please test this out on the dev branch, or the newly-released 2.15_02?

usmonster commented 8 years ago

Haven't tested, but what is the desired behavior for this use case:

mkdir temp foobar
echo 'Bongo!' > temp/dir.txt
cp temp/dir.txt foobar/
ack --ignore-dir=temp Bongo *

? Thanks!

petdance commented 8 years ago

Anything specified on the command line overrides whatever exclusions may happen because of switches. In this case, ack Bongo * expands to ack Bongo temp and that temp overrides --ignore-dir=temp.

usmonster commented 8 years ago

Makes sense to me--thanks for the clarification!

petdance commented 7 years ago

This went out in 2.16.