search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Add new 'i18n' filetype for translation source files #528

Closed knowledgejunkie closed 8 years ago

knowledgejunkie commented 9 years ago

This update adds support for a new 'linguist' filetype which covers Qt Linguist translation source (.ts) files, used to provide i18n support to Qt applications.

petdance commented 9 years ago

I'm wary of putting this in. I've never heard of Linguist before.

Also, from the man page:

All enhancement requests MUST first be posted to the ack-users mailing
list at <http://groups.google.com/group/ack-users>. I will not consider a
request without it first getting seen by other ack users. This includes
requests for new filetypes.
knowledgejunkie commented 9 years ago

Sorry about not posting to ack-users first, I've just posted an RFC. Could that text be added to https://github.com/petdance/ack2/blob/dev/DEVELOPERS.md?

Linguist is the Qt alternative to GNU gettext. Searching for "<!DOCTYPE TS>" on Github yields ~1.2m results. I use it to maintain and analyse translations for MythTV.

hoelzro commented 9 years ago

I've added a reference to the passage to CONTRIBUTING.md, and pointed readers of DEVELOPERS.md to that document.

knowledgejunkie commented 9 years ago

Thank you

knowledgejunkie commented 9 years ago

Updated to add a generic 'i18n' filetype in lieu of specific 'linguist' filetype. This approach has some support on the mailing list.

Add a generic 'i18n' filetype to provide filtering of translation files commonly found in source code trees.

Filetypes supported in this initial commit are:

petdance commented 8 years ago

Thanks for the input. I'm going to leave it out for now because I don't want to add new filetypes based on a single person requesting it.