beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Windows files with punctuation break -x (Read the list of files to search from STDIN) #545

Closed n1vux closed 4 years ago

n1vux commented 9 years ago

Issue with filenames read from STDIN, likely involving presumed special character quoting on Windows?

   dir *.doc /b | ack -lnx -is "lenovo"

as the files Srikanth surely has per dir /b are being rejected as not there. All of the bad filenames have Unix punctuation in their Windows filenames. I fear we're mishandling those. Perhaps we can reproduce on Linux, but we need Windows test case for sure also. (I would still recommend against Word/Office users accepting punctuation in default file names, same as against spaces, but we lost that battle decades ago.)

( Per email report "-s option does not work" on ack-users re searching *.doc on Windows; don't do that, but -x also broken on Windows. )