search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Add CVS merge backups to ignore list #556

Closed h3xx closed 9 years ago

h3xx commented 9 years ago

Yes, some of us still use CVS.

History lesson:

When a cvs update merges changes into a locally-modified file, it saves a copy of the file by renaming it so it looks like .#file.c.1.7.

Typically nobody cares about these files.

petdance commented 9 years ago

Yes, some of us still use CVS.

I'm glad you started your comment with this because that would have been my first question. :-)

petdance commented 9 years ago

Please post this change request to the ack-users list so that people can comment, either here or on the list. I'm concerned that there might be legitimate uses for files in the form foo.#1 that we would be excluding.

Also, have you been using that ignore in your .ackrc? For how long?

h3xx commented 9 years ago

Ah okay, I'll start the process mentioned in the CONTRIBUTING.md document. Have to sign up for a google account first.

petdance commented 9 years ago

This pull request is fine to leave open. I just want to get public commentary, so that it's not just the two of us deciding "This is an OK change to make."

h3xx commented 9 years ago

After a good long offline think about this merge request, I have come to the conclusion that it's not useful enough to be considered a "clean default" for ack to operate on. I will keep it in my .ackrc until my code shop moves to git, at which point it will be deleted and never needed again.

petdance commented 9 years ago

Thanks for your honest assessment. I appreciate it.