search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 140 forks source link

Revert b3617f1 and e3a5b3c #572

Closed hoelzro closed 8 years ago

hoelzro commented 9 years ago

The optimizations introduced in the mentioned commits have caused various regressions (#571, #562, #491, #498), so in spite of the performance gains, they need to be reverted. The revert isn't trivial (otherwise I would have done it), but it shouldn't take a determined contributor too long.

hoelzro commented 9 years ago

@petdance I've finished the revert and added some tests. However, this invocation of ack still gives output:

$ echo "\n\n\n" | ./tack '^(\s+)'  | wc -l
4

This is because \s is matching the \n at the end of each line; to me, that's unrelated to this issue or the abovementioned ones. Want me to file a new issue for this behavior and mark this issue as resolved?

petdance commented 8 years ago

The main task of reverting is done, right? Can we make the still problematic note above be a new ticket?

hoelzro commented 8 years ago

@petdance Correct, and yes