search

beyondgrep / ack2

**ack 2 is no longer being maintained. ack 3 is the latest version.**
https://github.com/beyondgrep/ack3/
Other
1.48k stars 138 forks source link

Add kotlin support #621

Closed nwolff closed 6 years ago

nwolff commented 7 years ago

filename extensions are .kt and .kts : https://en.wikipedia.org/wiki/Kotlin_(programming_language)

I'm able to search in kotlin files by adding 

--type-add=kotlin=.kt,.kts

to .ackrc

It would be nice if the type was there by default in ack.

I'll create a pull request if you give me the greenlight for this.

petdance commented 7 years ago

I'd like to hear from anyone else using Kotlin. Isn't it a pretty new language?

gimlet2 commented 7 years ago

@petdance Kotlin is growing pretty fast - on Android and as general replacement of Java. For example we have several services in production. Please add Kotlin type!

vanniktech commented 6 years ago

@petdance can we please add this? Especially giving that Android now fully supports Kotlin as a first party language.

petdance commented 6 years ago

Are those the only two rules? Kt and kts? Does it run from shell and we need to add a shebang? Any other special rules like how Rakefile is another Ruby file?

On Dec 16, 2017, at 4:50 AM, Niklas Baudy notifications@github.com wrote:

@petdance can we please add this? Especially giving that Android now fully supports Kotlin as a first party language.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

petdance commented 6 years ago

Added in 54026a3. Will be in 2.21_01.

vanniktech commented 6 years ago

This should be enough. Thanks for adding it :)