search

beyondscreen / fivetwelve-driver-usbpro

fivetwelve driver for the ENTTEC USBPRO family of interfaces
Other
3 stars 3 forks source link

Use new Serialport isOpen boolean API #2

Closed ericvicenti closed 5 years ago

ericvicenti commented 6 years ago

I was getting errors about isOpen being a boolean, because apparently serialport has changed the API here

ericvicenti commented 6 years ago

cc @cinderblock

TimPietrusky commented 5 years ago

We should also update the documentation to reflect which version of node-serialport is working with the driver.

@ericvicenti Do you know when this change in the API was introduced?

cinderblock commented 5 years ago

Looks like this change happend in SerialPort 5.x https://github.com/node-serialport/node-serialport/blob/160cf33bdbf331775ae2ccce8f374ec9e0988048/packages/serialport/UPGRADE_GUIDE.md#upgrading-from-4x-to-5x

Maybe this should be updated to test if isOpen is a function or not?