search

beyondscreen / node-rpi-ws281x-native

native bindings to drive WS2811 (or WS2812) LED-Controllers on a Raspberry Pi
MIT License
224 stars 101 forks source link

node-rpi-ws281x-native linked to an old version of your fork of rpi_ws281 lib #102

Open jimbotel opened 4 years ago

jimbotel commented 4 years ago

Hi @usefulthink ,

It looks like node-rpi-ws281x-native is linked to an old version of your fork of rpi_ws281 lib. See: https://github.com/beyondscreen/node-rpi-ws281x-native/tree/master/src so the changes introduced for RPI4 support are not effective in node-rpi-ws281x-native. Can you please take a look at that? Thanks!

Jaime.

usefulthink commented 4 years ago

this is probably true, haven't updated it in a while. Are you using the rpi-ws281x-native@next version? The older version will very likely not receive any further updates.

jimbotel commented 4 years ago

Hi @usefulthink . No, I'm using v0.9.0 . I didn't test @next (this is currently out of my control, I'm working with another repository that makes use of this one). I think @JeffJassky tested @next and he was not able to complete the build.

JeffJassky commented 4 years ago

@jimbotel it has been quite a white since testing. I do not recall what the issue was at the time. It's possible the issue may have been resolved already and it's possible the issue may have been my environment. It should be tested again.

ckirmse commented 4 years ago

The latest version, 0.10, no longer uses a fork of rpi-ws281x lib, so it should work fine now. This issue should be resolved.

jimbotel commented 4 years ago

hi @ckirmse . Thanks for letting me know, I didn't know that. I'll give it a try