switch from using NAN to NAPI

ckirmse commented 4 years ago

NAPI gives long-term support
old code had tight v8 dependencies that do not work with node 12 and later
also changed to use a newer version of the native code that has better error codes

ckirmse commented 4 years ago

No, the upstream repo is fine!ChrisOn Jul 6, 2020 2:50 AM, Martin Schuhfuss notifications@github.com wrote: @usefulthink approved this pull request.

First of all, sorry for not noticing this earlier and thank you sooooo much for putting the time into this. Was on my list of things to do once I get around to it (I didn't for quite some time as you can tell). Besides the one question above this all looks perfectly fine. I can even use your code as a blueprint to also update the newer version of the api. (once I find the time, energy and raspberry pis to do that :D)

In .gitmodules:

@@ -1,3 +1,3 @@ [submodule "src/rpi_ws281x"] path = src/rpi_ws281x

url = https://github.com/beyondscreen/rpi_ws281x.git

url = https://github.com/ckirmse/rpi_ws281x.git

are there any changes to the upstream repo that you need for this? Otherwise I'd love to switch back to the upstream version.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

usefulthink commented 4 years ago

@ckirmse done! I published a new version (0.10.0) to npm with the @preview-tag.

Can you please install that (npm install rpi-ws281x-native@preview) and verify that it works?

ckirmse commented 4 years ago

OK I did that and it's working great. Nicely done!

usefulthink commented 4 years ago

alright! I updated the dist-tags, so you can now install your version as usual with npm install rpi-ws281x-native.

Thanks again!

beyondscreen / node-rpi-ws281x-native

switch from using NAN to NAPI #105