[v1.x] Fails install / build

beyondscreen / node-rpi-ws281x-native

native bindings to drive WS2811 (or WS2812) LED-Controllers on a Raspberry Pi

MIT License

224 stars 101 forks source link

[v1.x] Fails install / build #119

Closed Toshimonster closed 3 years ago

Toshimonster commented 3 years ago

Build fails, seems to be mainly based upon the error:

/node-gyp/15.11.0/include/node/v8.h:2915:40: note:   candidate expects 1 argument, 0 provided
../src/rpi-ws281x.cc:173:44: error: no matching function for call to ‘v8::Value::ToObject()’
   Local<Object> buffer = info[1]->ToObject();

Perhaps this is a node versioning error?

Toshimonster commented 3 years ago

Also, realistically, it would be beneficial to merge v1.x into master, and leave the old master as legacy. The current branch is vastly inferior, and all activity is being promoted onto that branch instead of the v1.x one.

Toshimonster commented 3 years ago

This seems to be based on node versioning; node 12 fails, node 10 succeeds

Toshimonster commented 3 years ago

This is solved with the https://github.com/beyondscreen/node-rpi-ws281x-native/pull/115 pull.