search

beyonk-group / gdpr-cookie-consent-banner

A GDPR compliant cookie consent banner implementation
MIT License
248 stars 42 forks source link

Suggestion: Icon button do not have an accessible name #30

Closed mikeazores closed 1 year ago

mikeazores commented 2 years ago

First of all, thank you for developing this great plugin.

I'm using it on a static site generated with SvelteKit and is working just great. As it is more important adapt the websites to disabled people, I care a lot my websites to have full score in accessibility area.

The icon button in this plugin (to manage the cookie settings) fails in accessibility area because it misses the "aria-label" tag. You can read more on this here.

Is it possible to add this tag to that button? It would also be great that if the "aria-label" would be the same as the settingsLabel prop.

enyo commented 2 years ago

Just saw the same thing: my lighthouse (web.dev) score dropped after adding this library.

antony commented 1 year ago

done!