update to ^10.0.0 in Sveltekit project: minor TS error

beyonk-group / gdpr-cookie-consent-banner

A GDPR compliant cookie consent banner implementation

MIT License

248 stars 42 forks source link

update to ^10.0.0 in Sveltekit project: minor TS error #48

Closed 0gust1 closed 1 year ago

0gust1 commented 1 year ago

Just updated the component in our Sveltekit-based project:

now it works without this vite trick: https://github.com/beyonk-adventures/gdpr-cookie-consent-banner/issues/47#issuecomment-1495172142 (thanks and congrats!)
Our project is in Typescript and I noticed this small error:

0gust1 commented 1 year ago

It may be caused by the automatic type determination at build time and the fact that cookieName has a default null value. I'm uncertain of the changes to make, maybe try setting a default non-null string value ? or make the prop non optional (no default value) ?

antony commented 1 year ago

Yeah I'm no TS expert unfortunately. If somebody knows how to fix this they probably should!