beyonk-group / gdpr-cookie-consent-banner

A GDPR compliant cookie consent banner implementation
MIT License
248 stars 42 forks source link

Update package.json - Svelte peer dependency, add v4 #51

Closed 0gust1 closed 1 year ago

0gust1 commented 1 year ago

fixes #52

A proposal to support the recent release of Svelte V4.

It was checked locally on ~our SvelteKit project~ two different production-used sveltekit-based projects, no problems so far.

We may eventually check and add the |global modifier on the transitions used in src/lib/Banner.svelte, but IMHO, it's not necessary.

Refs:

0gust1 commented 1 year ago

@antony First, sorry for the tagging (I feel a little bad, forgive me if you find this rude).

Can we consider moving forward with this ? On our current project, gdpr-cookie-consent-banner (which I quite glad to use) is the last dependency preventing us from migrating to svelte v4.

antony commented 1 year ago

Hey @0gust1 - absolutely. My apologies for not merging this sooner!

I get so many notifications I don't see them, so thanks for reaching out :)