search

beyonk-group / google-fonts-webpack-plugin

47 stars 24 forks source link

Bumped compatible webpack version to 5 #14

Closed dakur closed 3 years ago

dakur commented 3 years ago

@antony Readme change as well.

Btw, publish to npm failed for some reason, can you please take a look at it?

dakur commented 3 years ago

@antony This is just quick review.

antony commented 3 years ago

The npm publish failed because the tests failed - so they need to be fixed. I don't have time to fix them unfortunately.

dakur commented 3 years ago

@antony It seems to me like they failed just once accidentally. I've tried to run it in a fork and they passed well. Re-run should be enough.

But I've made follow-up PR which fixes BC break with webpack v4 and runs test on every push as well.

antony commented 3 years ago

Alright - I'll take a look. Thanks

On Sat, 10 Apr 2021 at 10:14, dakur @.***> wrote:

@antony https://github.com/antony It seems to me like they failed just once accidentally. I've tried to run it in a fork and they passed well https://github.com/dakur/google-fonts-webpack-plugin/runs/2312006750. Re-run should be enough.

But I've made follow-up PR which fixes BC break with webpack v4 and runs test on every push as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/beyonk-adventures/google-fonts-webpack-plugin/pull/14#issuecomment-817105680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABVORO72M25GWJ5C65J2ITTIAJHHANCNFSM4ZKDHDYA .

--

ꜽ . antony jones . http://www.enzy.org