search

beyonk-group / svelte-google-analytics

Google Analytics component for Svelte
77 stars 12 forks source link

Add function for setUserProperties #9

Closed madanifaz closed 3 years ago

madanifaz commented 3 years ago

I added function to set user properties like location or custom defined one, its useful when we need to split event by user properties on the google analytic dashboard.

See https://developers.google.com/analytics/devguides/collection/ga4/user-properties for reference docs.

antony commented 3 years ago

Looks good - could you include a section about it in the README too?

madanifaz commented 3 years ago

Oh, I am sorry I forget it.

madanifaz commented 3 years ago

I am sorry can it be merged ? or there anything else todo ? i already update the readme.

antony commented 3 years ago

Hi There

I've just merged this into master - sorry it took so long.

I noticed a new function at the top of generated-functions.js - as the name implies, this file is auto-generated by a script, so anything you put in there will get wiped. Can you move those functions to another place so that they don't get wiped please :)

madanifaz commented 3 years ago

oh, i am sorry, sure i will move it to another place