search

bezhanSalleh / filament-panel-switch

The Panel Switch Plugin for Filament offers a robust and customizable component for switching between panels in applications built with FilamentPHP.
MIT License
123 stars 21 forks source link

[Feature] Handle Panel Domains #15

Closed bezhanSalleh closed 1 year ago

bezhanSalleh commented 1 year ago

Closes #13

andrewdwallo commented 1 year ago

@bezhanSalleh This PR did not fix #14 or #12. Your suggestion or "fix" to use a different render hook does not work as well... unless I put the panel switch button inside the page body or something. The only thing that does work with topNavigation enabled is using the simple method for the panel switch, nothing else.

When using topNavigation, clicking on the button to open the panel switch modal does absolutely nothing.

bezhanSalleh commented 1 year ago

There was supposed to be an issue regarding what the title of the PR says weird 🤔. Anyhow, I haven't looked into top navigation issue and this is for what it says. Apologies for misleading comment.

andrewdwallo commented 1 year ago

Sorry. I was just commenting here because I noticed that you closed both of the issues that I mentioned above saying that this PR fixes those issues. That is what I was commenting about. I wasn't commenting about the "Handle Domains" feature.

Anyways, I found the fix for both #14 and #12 and will be submitting a PR for it shortly. Thanks.

bezhanSalleh commented 1 year ago

Sweet,I have reopened them so be sure to mention it in your PR.

andrewdwallo commented 1 year ago

Sounds good!