search

bezmi / homeassistant_jvc_projector_remote

Custom components for homeassistant
Apache License 2.0
14 stars 11 forks source link

Add support for Home Assistant Community Store (HACS) #1

Closed frankrosano closed 4 years ago

frankrosano commented 4 years ago

This PR adds "custom repository" support for the Home Assistant Community Store (HACS). This will make installation and upgrades much easier for the end user.

bezmi commented 4 years ago

This is great, I haven't been in the loop enough to realise that HACS is now a thing. I'm inclined to merge straight away as the changes are minimal. Are you confident that this will install through HACS as expected? I have very little time to test.

frankrosano commented 4 years ago

Yes sir, I currently have it installed in my instance via HACS pointed to my forked repo, so once this is merged in it should be good to go with your official repo.

By the way, thanks for writing this integration. I was about to write my own to control my JVC projector when I did one last google search and came across yours, so saved me a ton of time :).

bezmi commented 4 years ago

Merged! You're very welcome. I've only implemented a subset of the controls that I need, so if you end up adding any extra features to the python module, be sure to submit a pull request.

frankrosano commented 4 years ago

Awesome! My use case is literally just turn on / turn off lol but the completionist in me might like to have more controls available "just in case". I'll probably work towards implementing more, will definitely submit a PR if/when they're ready. Thanks!