search

bezoerb / text-metrics

An efficient text measurement set for the browser
MIT License
63 stars 4 forks source link

Wrong conversion to pixels from points #13

Closed omerts closed 3 years ago

omerts commented 3 years ago

Hey,

Thanks for the lib, really helpful. Seems like there is a small bug with the conversion from pts to inch. Current implementation:

return value / (96 / 72);

Should be:

return value * (96 / 72);
omerts commented 3 years ago

Created https://github.com/bezoerb/text-metrics/pull/14

bezoerb commented 3 years ago

Good catch 😊 PR is merged. Thanks @omerts