search

bf2fc6cc711aee1a0c2a / architecture

Repository containing the architecture documents.
https://architecture.bf2.dev/
Apache License 2.0
5 stars 20 forks source link

feat: AP 17 Fleet shard status #82

Open shawkins opened 1 year ago

shawkins commented 1 year ago

Resolves #81: this covers the pattern for fleet shard status that was discussed in an architecture call and several follow-up working group meetings.

The only major pending change is that @lburgazzoli would like to expand on the current vs desired state section to include a recommendation on using a generation field to know more precisely when the condition was observed. That can be added after an initial merge if needed.

cc @tombentley

lburgazzoli commented 1 year ago

@shawkins will get back this week hopefully

tombentley commented 1 year ago

@shawkins sorry to have dropped the ball so badly on this. Does it still need reviewing?

shawkins commented 1 year ago

@shawkins sorry to have dropped the ball so badly on this. Does it still need reviewing?

Yes it still needs to be reviewed. There are some pending changes from @lburgazzoli that I'll make part of this pr as well.

shawkins commented 1 year ago

@lburgazzoli incorporated the changes from the google doc, but omitted the part about polling based upon generation - that seems out of scope for this doc and would probably need to mention a watching paradigm in addition to polling.

@tombentley should be ready for review now.

shawkins commented 1 year ago

@emmanuelbernard @danielezonca please review or delegate so that this can move forward

tombentley commented 1 year ago

@emmanuelbernard still waiting for your review on this one.