search

bf2fc6cc711aee1a0c2a / architecture

Repository containing the architecture documents.
https://architecture.bf2.dev/
Apache License 2.0
5 stars 20 forks source link

feat: add ADR for certs management #83

Closed machi1990 closed 1 year ago

machi1990 commented 2 years ago

The ADR intends to supersede https://architecture.appservices.tech/adr/5/

machi1990 commented 2 years ago

@emmanuelbernard @tombentley can I get a review on this? It is related to https://issues.redhat.com/browse/MGDSTRM-10159

machi1990 commented 1 year ago

@pb82 @shawkins can you have a look?

Once accepted by you, i'll add another commit to mark the https://architecture.appservices.tech/adr/5/ as superseded by this one and I'll then add the status of the ADR as accepted.

pawelpaszki commented 1 year ago

@machi1990 - the ADR makes sense to me. I will let others review as well

machi1990 commented 1 year ago

Thanks for the review @pawelpaszki and the suggestions. I'll apply them and wait for review from others as well.

machi1990 commented 1 year ago

thanks for the review @emmanuelbernard i've pushed some updates and answer the questions. Please have another look when you get a chance to.

shawkins commented 1 year ago

@pb82 @shawkins can you have a look?

Once accepted by you, i'll add another commit to mark the https://architecture.appservices.tech/adr/5/ as superseded by this one and I'll then add the status of the ADR as accepted.

LGTM

thanks @machi1990

machi1990 commented 1 year ago

Thanks @emmanuelbernard @shawkins @pb82 for the review.

@emmanuelbernard I do not have merge permission on the repo, can you do the honor for me? Thanks