search

bf2fc6cc711aee1a0c2a / kafka-admin-api

Backend operations in the UI for the Kafka service.
Apache License 2.0
1 stars 10 forks source link

Propagate 403 handling to the openapi spec #243

Closed andreaTP closed 1 year ago

andreaTP commented 1 year ago

We have noticed that more endpoints were throwing 403 responses. Since the mapper for 403 is common I expanded the specification to keep 403 always into account.

This change is needed to generate better/nicer error-handling code in generated clients.

andreaTP commented 1 year ago

Thanks @MikeEdgar for the prompt answer, no we got it on the list topics endpoint, I can remove the 403 from /acls/resource-operations if desired.

MikeEdgar commented 1 year ago

I can remove the 403 from /acls/resource-operations if desired.

I think it's fine to declare it on all of them :+1:

andreaTP commented 1 year ago

the CI got stuck apparently, something to do with this PR?

MikeEdgar commented 1 year ago

the CI got stuck apparently, something to do with this PR?

I don't think it's due to these changes. Probably just GitHub load or service issues. I just retriggered it.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication