Closed shawkins closed 2 years ago
Kudos, SonarCloud Quality Gate passed!
small nit, maybe put the annotation string in the utility class that Mike created?
That seemed to be for our annotations, not the ones for third-party stuff - the strimzi, ingress, etc. annotations are not managed in that way yet.
That seemed to be for our annotations, not the ones for third-party stuff - the strimzi, ingress, etc. annotations are not managed in that way yet.
That was the intent, yes. Specifically the managedkafka.bf2.org
prefixed ones.
PodSet pods won't have a parent deployment. This annotation will allow them to still be movable by the auto-scaler. This does not yet address a non-developer bin-packing scenario as we're not sure if that will be needed.