search

bf2fc6cc711aee1a0c2a / kas-fleetshard

The kas-fleetshard-operator is responsible for provisioning and managing instances of kafka on a cluster. The kas-fleetshard-synchronizer synchronizes the state of a fleet shard with the kas-fleet-manager.
Apache License 2.0
7 stars 20 forks source link

MGDSTRM-9666 removing labels that may change from reserved selectors #811

Closed shawkins closed 2 years ago

shawkins commented 2 years ago

I was mistaken that this could be addressed by using a patch - the selectors are still immutable. The proper way to do this is to just choose labels that won't change, similar to what is applied to our other deployments.

rareddy commented 2 years ago

so if you have the right selectors then the PUT call works fine?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

shawkins commented 2 years ago

so if you have the right selectors then the PUT call works fine?

Yes. The problem here is having managedkafka.bf2.org/strimziVersion: "strimzi-cluster-operator.v0.23.0-4" in the selectors - I was just reusing the Kafka.metadata. However you aren't allowed to change that after the deployment is created.

machi1990 commented 2 years ago

Thanks @shawkins @rareddy

machi1990 commented 2 years ago

Can this be included in the 0.29 release @rareddy @MikeEdgar @shawkins ?