search

bf2fc6cc711aee1a0c2a / kas-fleetshard

The kas-fleetshard-operator is responsible for provisioning and managing instances of kafka on a cluster. The kas-fleetshard-synchronizer synchronizes the state of a fleet shard with the kas-fleet-manager.
Apache License 2.0
8 stars 20 forks source link

[MGDSTRM-9807] Separate image-jib to active-by-default profile #889

Closed MikeEdgar closed 1 year ago

MikeEdgar commented 1 year ago

This seems to be the configuration that will allow us to skip the JIB processing when needed.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MikeEdgar commented 1 year ago

Since it's the same profile and we reference it from the root pom.xml, what about moving it up to root?

I considered that but I didn't like that it would be added to all the other modules via the parent.

rareddy commented 1 year ago

Couple questions

I considered that but I didn't like that it would be added to all the other modules via the parent.

why we do not want for all the modules?

since we use the profile in release, the metadata file as u were saying will show up in the image anyways, then what are we gaining by putting it in profile?

MikeEdgar commented 1 year ago

why we do not want for all the modules?

It's only sync and operator that need it when doing a JIB image build. The others like api, common, and the test modules don't use it for anything.

since we use the profile in release, the metadata file as u were saying will show up in the image anyways, then what are we gaining by putting it in profile?

The release profile is used for GitHub releases, but we don't use that profile for the product build.