search

bfabiszewski / ulogger-server

μlogger • web viewer for tracks uploaded with μlogger mobile client
GNU General Public License v3.0
522 stars 85 forks source link

Add ULOGGER_BASE_URL variable #181

Closed gjedeer closed 2 years ago

gjedeer commented 2 years ago

This is to fix https://github.com/bfabiszewski/ulogger-server/issues/145

The way it's usually done in projects supporting Docker is - just allow the user to supply their own base path, instead of guessing your own. This patch implements that behavior, I'm not sure if the code is up to your standards.

bfabiszewski commented 2 years ago

Thanks! That's clever idea, but I don't want to go in this direction.

I've just removed all variables but database setup from config file. I also don't see a point to increase complexity of base URL detection. For most cases it works fine. And I have to keep it simple, because of lack of time for extensive support.

I don't have time now to play with proxies or docker but I think the problems might be solved with proxy setup.

The docker I created is designed for testing and is not production ready. For production docker there could be an option to install the app in a subfolder of the root directory, effectively changing base URL if that is needed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.