search

bfaloona / monologues

monologues rails website
0 stars 1 forks source link

Interim solution for monologues without content #17

Closed slshults closed 14 years ago

slshults commented 14 years ago

How hard would it be to make the first line link to the pdf for the monologues which don't yet have the body/preview text?

This way people would get the pdf when they click the first line until I get around to adding the preview text etc.

Readily doable or an unwieldy beastie from hell?

bfaloona commented 14 years ago

done. pdf_link used when monologue.nil?

slshults commented 14 years ago

Sweet. Awesome first pass on that, so quick you are! That must be the 'rails' part? :-)

I noticed that it got many of them right but some just link back on themselves (just reload the page when clicked (both the first line and the pdf icon.)

Henry V and Richard III are good examples. Click through like 5 monos on each and you'll run into it.

bfaloona commented 14 years ago

Yeah, it can't link to the pdf, if there is no pdf_link value! So, round two is checked in: 1) print a link to the monologue if there is a body. 2) print a link to the location if there is one (I've not tested this one. not sure if any lack a location) 3) print a link to the pdf if there is one, otherwise display a faded pdf icon without a link (search for othello to see that one in action)

slshults commented 14 years ago

Hmm. went to check on results and when i go here http://monologues.heroku.com/men/ and click link i get the generic ruby error.

bfaloona commented 14 years ago

that was the plays bug, so this one can be closed for now, right?

slshults commented 14 years ago

yep. looks great, thanks! closing...