search

bfanger / angular-activerecord

A model layer for AngularJS inspired by Backbone.Model
MIT License
137 stars 28 forks source link

Add single-loaded(from server) relations declaration using `$relations` property #26

Open ajcastro opened 8 years ago

ajcastro commented 8 years ago

Please see the Defining Relations section in the README.md of my fork. Thanks! :)

PS: This has no automated test but I tested it manually.

ajcastro commented 8 years ago

Woah, why did the build break?

bfanger commented 8 years ago

Previous Travis-CI build was 8 months ago, I've updated the configs and dependencies. if you'd git rebase it probably fixes this build too.

ajcastro commented 8 years ago

Im sorry but Im not sure how to do that git rebase. I didn't get how to solve the problem.

bfanger commented 8 years ago 
git remote add upstream https://github.com/bfanger/angular-activerecord.git
git pull --rebase upstream master
# check if the patch still works after the rebase
git push -f origin master

For more detailed information: stackoverflow.com/How do I clean up my Github fork so I can make clean pull requests?

bfanger commented 8 years ago

I like the simplicity of your implementation of relations (just mapping the objects to classes), but managing relations is a feature that can become complex really fast.

Could you write the relation feature as a separate optional js file? like a plugin?

var initialize = ActiveRecord.prototype.$initialize;
ActiveRecord.prototype.$initialize = function $initialize(properties, options) {
    initialize.apply(this, arguments);
    ... relation code here ...
}

That way ActiveRecord matches Backbone.Model and people can opt-in to your implementation of use their own.

ajcastro commented 8 years ago

Sorry for the late reply, I was busy this past few days. Btw, thanks for the compliment and instructions. I will do it shortly.

ajcastro commented 8 years ago

I am puzzled how to do put it in a separate optional js file. Maybe you can help me. Currently I'm still googling how to do that.

ajcastro commented 8 years ago

Aha! I think I had to create another factory, which of course has a different name e.g. ActiveRecord.Slr, and it has a dependency on ActiveRecord. Slr means single-loaded-relations.

ajcastro commented 8 years ago

I need help on this, I don't know yet how to fix this. I am still a newbie in karma/angular js unit testing. https://travis-ci.org/ajcastro/angular-activerecord/builds/142970284

I already pushed my code in branch activerecord-slr in my fork. Thanks :)

bfanger commented 8 years ago

Thanks I'll try to merge it when I've got some free time