search

bfarago / fdms2tools

Fostex D80 filesystem reader lib and windows tool to export (sience 2006)
GNU General Public License v3.0
0 stars 0 forks source link

Divison by zero in v1.0.0.6 binary release #1

Closed bfarago closed 6 years ago

bfarago commented 6 years ago

The old version of the sw 1.0.0.6 could stop on a divison by zero issue in .code offset: d4e4. (address 0x40d4e4) Yes there is a div, instruction.

Actually I have no pdb file, or original sources also not found yet, so I am not sure which part of the code is involved on this. In the actual version, I will add Asserts and some run-time protection before the divisions. (sourceforge shuts down the csv service, so I was not able to reproduce the same code, same situation)

I had no issues in my Pc, with my test setup... This issue was happened on specific windows versions, therefore I assume the issue was influenced by os reports of the default "page size" or somehow on the GDI/gui part of the sw. (window width) Or possible on the actual wave length imported from disk.

crash2 crash1

bfarago commented 6 years ago

in v1.0.0.8: Every div/mod codes h b reviewed, dividers protected by zero check, issue somehow handled.. Need to test, verify the result... (Same situation something else will happen now, like wrong zoom, etc)

bfarago commented 6 years ago

Tested. Fixed.