search

bfast2 / bfast

Breaks For Additive Season and Trend
https://bfast2.github.io
GNU General Public License v2.0
41 stars 15 forks source link

bfastpp: more flexible handling of season #47

Closed GreatEmerald closed 4 years ago

GreatEmerald commented 4 years ago

At the moment, bfastpp assumes that the user wants to estimate one parameter per time step of the input time series for a year. However, that makes it impossible to use season with h below one year. In addition, bfastpp also assumes that the frequency is an integer, which is not necessarily the case.

GreatEmerald commented 4 years ago

Implemented in our cglops code, can be upstreamed: https://github.com/GreatEmerald/cglops-change-detection/blob/3462b27c8d1017f928aedb65f0aa7dc35832fede/src/bfast-cal/02-detectbreaks.r#L49

GreatEmerald commented 4 years ago

Fixed in #53