search

bfast2 / bfast

Breaks For Additive Season and Trend
https://bfast2.github.io
GNU General Public License v2.0
41 stars 15 forks source link

bfastmonitor doesn't validate inputs #66

Open mirt001 opened 3 years ago

mirt001 commented 3 years ago

bfastmonitor silently fails when inputs such as date, or startdate are not logically valid.

GreatEmerald commented 3 years ago

What does "silently fails" mean? It gives an output that is fake or something? A reprex would be useful.

I'd also argue that it's a bug and not enhancement ;)

mirt001 commented 3 years ago

we discussed it privately already, but just for the record. the issue is that there is no sanity check. e.g. you can analyze a dataset spanning from 2010 to 2020 and ask it to check for breaks after 2025. bfastmonitor behaves correctly in the sense that it calculates that there are no breaks after 2025, but I believe it is preferable to not attempt to give an answer to this question.

Whether it's an enhancement, or a bug depends on what the author intended. I have no clue about that, so I was conservative and I assumed that the author intended it to work as it does. I believe it would be better if it would work as I explained, which would make it an enhancement. If you know it's a bug, please relabel.