bfast2 / bfast

Breaks For Additive Season and Trend
https://bfast2.github.io
GNU General Public License v2.0
41 stars 15 forks source link

Deduplicate strucchange code in BFAST #71

Open GreatEmerald opened 3 years ago

GreatEmerald commented 3 years ago

bfast01 (classify?) is using some code taken from strucchange; try to deduplicate it by integrating the changes into strucchangeRcpp.

GreatEmerald commented 3 years ago

The functions in question are bfast01.confint and breakpoints.confint. To do: make tests in the examples section for both, then see if breakpoints.confint can be generalised to cover both cases. E.g. run breakpoints(breaks=1) and see if it's estimated the same way with bfast01.confint.