search

bfast2 / bfast

Breaks For Additive Season and Trend
https://bfast2.github.io
GNU General Public License v2.0
41 stars 15 forks source link

Fix set_fast_options() for R CMD check #73

Closed appelmar closed 3 years ago

appelmar commented 3 years ago

R CMD check gives 

> set_fast_options()
Error in as.environment("package:strucchange") : 
  no item called "package:strucchange" on the search list
Calls: set_fast_options
appelmar commented 3 years ago

Let's discuss later. As it is, it only solves the examples and set_fast_options only works if users explicitly call library(strucchangeRcpp) before. To solve this, we could add the strucchangeRcpp package as Depends instead of Imports.

GreatEmerald commented 3 years ago

Yes, but best to write a new issue so that we don't get lost :)

GreatEmerald commented 3 years ago

Oh, never mind, this is the issue, I thought this was the pull request!

GreatEmerald commented 3 years ago

Fixed in #78 by putting strucchangeRcpp into Depends.