Bad title position on the iPhone X emulator

[sm-tester]

Hi, thank you for great library!

I found following bug on the iPhone x emulator, look to screenshot:

Do you have any suggestions how to fix it?

Thank you in advance!

[bfeher]

Hi @boyfox !

When I run the command pod try BFPaperTabBarController and get the default app up and running it works how iPhone X specifications state that it should:

Are you doing anything custom with this control or maybe some AutoLayout issues with the new Safe Zones?

[sm-tester]

HI @bfeher !, Sorry for later replying, i bought iphone x and checked again, same issuse:

I'm using CustomUITabBar class for setting fixed height:

-(CGSize)sizeThatFits:(CGSize)size {
    CGSize sizeThatFits = [super sizeThatFits:size];
    sizeThatFits.height = 54; // 54pt - design in iphone 6 plus

    return sizeThatFits;
}

and i'm using vector images such as pdf files for icons.

others devices works fine:

Do you have any suggestion, i need increasing tab bar height just on Iphone X? can i get standart device tabbar height for checking?

[bfeher]

Hi @boyfox!

Hmm. This seems like an issue with the new Safe Areas. Have you enabled them in your app? It looks like the content of the bar itself is pushed up correctly with safe zones, but the background isn't.

I can't reproduce this so I can only guess. Do you get the same results if you use a standard UITabBarController?

[sm-tester]

Yes, @bfeher you are right, Safe area stayed turn off in my project. But i can't switch on it, because my deployment target is iOS 8.0 .

Do you have any suggestions to fix it?

[bfeher]

When I updated my apps I had a problem where the entire UITabBar was below the Safe Area. I adjusted the Autolayout property and it worked perfectly. However what is strange in your case is that only the background and icons are in the original position while the bar itself is correctly positioned. Perhaps some of your auto layout constraints within the bar need new values when on the iPhone X? (Since you support iOS 8 and can't use Safe Area, maybe you can check if you are on the iPhone X and push up your constraints which are probably set to zero, to the height of the safe area?)

[sm-tester]

ok @bfeher thank you for suggestions, you can close or remove this issue, because this is not a bug of library. Thank you for great library!

[bfeher]

@boyfox Sorry that I couldn't help more. If you find out that it is this library, or want me to look at some code, let me know :)

[sm-tester]

Thank you @bfeher, you are best programmer! I removed custom UITabBar and works fine. Also works if I will increasing custom ui tabbar height if device model iphone X.

[bfeher]

;) You are too kind. I'm glad you could solve it!