bfeher / BFPaperTableViewCell

A subclass of UITableViewCell for iOS inspired by Google's Paper Material Design.
MIT License
368 stars 44 forks source link

Warning: assigning incompatible type #16

Closed Emailrus closed 7 years ago

Emailrus commented 7 years ago

Have 2 warnings:

Warning:(396, 39) assigning to 'id<CAAnimationDelegate> _Nullable' from incompatible type 'BFPaperTableViewCell *const __strong'

It seems that BFPaperTableViewCell () is missing conform to CAAnimationDelegate, so it might be pretty straightforward fix.

PS: in BFPaperCheckbox it seems to be already fixed

bfeher commented 7 years ago

Hi @Emailrus!

Thanks for using BFPaperTableViewCell and for bringing this to my attention. As you noticed in BFPaperCheckbox, this issue (introduced in iOS10 with the addition of CAAnimationDelegate) has been fixed by adding this line in '.h':

#if __IPHONE_OS_VERSION_MAX_ALLOWED < 100000
// CAAnimationDelegate is not available before iOS 10 SDK
@interface BFPaperCheckbox : UIControl <UIGestureRecognizerDelegate>
#else
@interface BFPaperCheckbox : UIControl <UIGestureRecognizerDelegate,CAAnimationDelegate>
#endif

I'm out of the office today at an expo, but when I return I will update this project with the same check. Thanks!

bfeher commented 7 years ago

Version 2.3.10 has this fix. Please update and let me know if you find anymore problems. Thanks again!

Emailrus commented 7 years ago

No problems, thank you very much