search

bfgroup / Lyra

A simple to use, composable, command line parser for C++ 11 and beyond
https://bfgroup.github.io/Lyra/
Boost Software License 1.0
471 stars 56 forks source link

Fix `command::operator|=` function signature #71

Closed BurningEnlightenment closed 1 year ago

BurningEnlightenment commented 2 years ago

The template parameter must be be used in the function signature in order to be deducable.

gegles commented 1 year ago

Hello, I was facing the same issue and figured out the same root cause and fix before finding this PR. Thanks @BurningEnlightenment!

@grafikrobot could we please merge this in ASAP?

Ideally if it could lead to a new conan release (v1.6.1?), that would be amazing, as we get Lyra through Conan center.

Otherwise, great library, thanks!

grafikrobot commented 1 year ago

Just added it to a 1.6.1 milestone for end-of-month, now that I'm done with prepping for the big WG21 meeting :-)

gegles commented 1 year ago

Just added it to a 1.6.1 milestone for end-of-month, now that I'm done with prepping for the big WG21 meeting :-)

Awesome, thanks @grafikrobot! This is really great news!

grafikrobot commented 1 year ago

@gegles sorry for the delay. Updating the CI testing took a while. And now I have covid, so it's making things slower. I'll try and get the patch release by end-of-week. But at the latest the 16th. And yes, it will show up in CCI. I also updated the CCI recipe for conan v2.