bfgroup / b2

B2 makes it easy to build C++ projects, everywhere.
https://www.bfgroup.xyz/b2/
Boost Software License 1.0
80 stars 229 forks source link

`<build>no` conditionals evaluation short circuiting #259

Closed Kojoley closed 1 year ago

Kojoley commented 1 year ago

Fixes #162

grisumbras commented 1 year ago

Maybe it's better to change evaluate-conditionals-in-context to actually stop evaluation once <build>no is encountered?

grafikrobot commented 1 year ago

Maybe it's better to change evaluate-conditionals-in-context to actually stop evaluation once <build>no is encountered?

@grisumbras Ah, isn't that what the PR is already doing?

grisumbras commented 1 year ago

I thought it didn't, but now I see that return does actually return from a rule. I am pretty sure this was not the case. When was that changed?

grafikrobot commented 1 year ago

@grisumbras It was done long ago enough that I don't remember :-) Definitely before the 4.0 series of b2.

grafikrobot commented 1 year ago

/backport

github-actions[bot] commented 1 year ago

Successfully created backport PR for version/4.10.0: