search

bfgroup / b2

B2 makes it easy to build C++ projects, everywhere.
https://www.bfgroup.xyz/b2/
Boost Software License 1.0
76 stars 228 forks source link

mock tests: is it supposed to work like that? #271

Open Kojoley opened 1 year ago

Kojoley commented 1 year ago

I kinda like it even, but what is the point of this beautiful but over engineered system? May I replace it with just b2 -n | FileCheck expected maybe? It would be much easier to maintain and work with while also faster to run. The only benefit of the current system is unordered match, it not used extensively though and actually confusing. When you finally see the error message good luck to figure out what changed.

grafikrobot commented 1 year ago

I would be rather happy if the whole mock thing went away. I didn't write the thing. And I can't think of a time when it detected a problem. I would prefer more low level / isolated unit tests.

Kojoley commented 1 year ago

And I can't think of a time when it detected a problem

Because it currently tests popular toolsets (except clang-vxworks) which are also tested in CI. It's much more useful for toolsets which can't be tested in CI, would save me from overthinking whether my change could break some rotting without CI toolset. It also tests only a tiny specific scenario. I once wanted to deal with #118 using mocking, but currently it drains too much time to set the tests up (and it also slow to run).